| From: | Paul Guo <pguo(at)pivotal(dot)io> |
|---|---|
| To: | a(dot)kondratov(at)postgrespro(dot)ru |
| Cc: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Jimmy Yih <jyih(at)pivotal(dot)io>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
| Subject: | Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown) |
| Date: | 2019-09-26 14:09:46 |
| Message-ID: | CAEET0ZFVJsf3AE1n2_GGE+5W9sevk+9aH0Ln6NBRKXO_O9SCQg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
>
> Yes, -R is already used in pg_basebackup for the same functionality, so
> it seems natural to use it here as well for consistency.
>
> I will review options naming in my own patch and update it accordingly.
> Maybe -w/-W or -a/-A options will be good, since it's about WALs
> retrieval from archive.
>
>
Thanks
>
> Regards
> --
> Alexey
>
> P.S. Just noticed that in v12 fullname of -R option in pg_basebackup is
> still --write-recovery-conf, which is good for a backward compatibility,
> but looks a little bit awkward, since recovery.conf doesn't exist
> already, doesn't it? However, one may read it as
> 'write-recovery-configuration', then it seems fine.
>
>
Yes, here is the description
"--write-recovery-conf write configuration for replication"
So we do not mention that is the file recovery.conf. People do not know
about the recovery.conf history might really not be confused since
postgresql has various configuration files.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mike Palmiotto | 2019-09-26 14:11:04 | Re: Auxiliary Processes and MyAuxProc |
| Previous Message | Paul Guo | 2019-09-26 14:05:16 | Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown) |