| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Extensions not dumped when --schema is used |
| Date: | 2021-04-15 08:28:49 |
| Message-ID: | CAECtzeW9TsOVBK0xQSYYg-eM5bwXtt-0n67QxBU6ZHooRt3iWg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Le jeu. 15 avr. 2021 à 09:58, Michael Paquier <michael(at)paquier(dot)xyz> a
écrit :
> On Wed, Apr 14, 2021 at 05:31:15AM -0700, Noah Misch wrote:
> > The name "without_extension_explicit_schema" arose because that test
> differs
> > from the "without_extension" test by adding --schema=public. The test
> named
> > "without_extension_implicit_schema" differs from "without_extension" by
> adding
> > --schema=regress_pg_dump_schema, so the word "implicit" feels
> not-descriptive
> > of the test. I recommend picking a different name. Other than that, the
> > change looks good.
>
> Thanks for the review. I have picked up "internal" instead, as
> that's the schema created within the extension itself, and applied the
> patch.
>
Thanks for the work on this. I didn't understand everything on the issue,
which is why I didn't say a thing, but I followed the thread, and very much
appreciated the fix.
--
Guillaume.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2021-04-15 08:42:42 | Schema variables - new implementation for Postgres 15 |
| Previous Message | Julien Rouhaud | 2021-04-15 08:11:42 | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |