Re: Default gucs for EXPLAIN

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Bruce Momjian <bruce(at)momjian(dot)us>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Default gucs for EXPLAIN
Date: 2020-05-26 14:44:59
Message-ID: CAECtzeVxAAq8qvHoH4GWH9+nCM24ms3iAWgdiyvY+PqZFhNFtg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Le mar. 26 mai 2020 à 16:25, Stephen Frost <sfrost(at)snowman(dot)net> a écrit :

> Greetings,
>
> * Guillaume Lelarge (guillaume(at)lelarge(dot)info) wrote:
> > Le mar. 26 mai 2020 à 04:27, Stephen Frost <sfrost(at)snowman(dot)net> a écrit
> :
> > > To that end- what if this was done client-side with '\explain' or
> > > similar? Basically, it'd work like \watch or \g but we'd have options
> > > under pset like "explain_analyze t/f" and such. I feel like that'd
> also
> > > largely address the concerns about how this might 'feature creep' to
> > > other commands- because those other commands don't work with a query
> > > buffer, so it wouldn't really make sense for them.
> > >
> > > As for the concerns wrt explain UPDATE or explain DETELE actually
> > > running the query, that's what transactions are for, and if you don't
> > > feel comfortable using transactions or using these options- then don't.
> >
> > This means you'll always have to check if the new GUCs are set up in a
> way
> > it will actually execute the query or to open a transaction for the same
> > reason. This is a huge behaviour change where people might lose data.
>
> It's only a behaviour change if you enable it.. and the suggestion I
> made specifically wouldn't even be a regular 'explain', you'd be using
> '\explain' in psql, a new command.
>
> > I really don't like this proposal (the new GUCs).
>
> The proposal you're commenting on (seemingly mine, anyway) didn't
> include adding any new GUCs.
>
>
My bad. I didn't read your email properly, sorry.

I wouldn't complain about a \explain metacommand. The proposal I (still)
dislike is Vik's.

--
Guillaume.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bossart, Nathan 2020-05-26 15:45:34 Re: race condition when writing pg_control
Previous Message Tom Lane 2020-05-26 14:43:31 Re: hash join error improvement (old)