Re: Extensions not dumped when --schema is used

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Extensions not dumped when --schema is used
Date: 2021-02-18 10:13:06
Message-ID: CAECtzeV9+TnuKYrj8XUBmRAhVu9ftyiM6-BKVUS1L6=r=zFCng@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Le mar. 26 janv. 2021 à 13:42, Guillaume Lelarge <guillaume(at)lelarge(dot)info> a
écrit :

> Le mar. 26 janv. 2021 à 13:41, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
> a écrit :
>
>> Le mar. 26 janv. 2021 à 05:10, Julien Rouhaud <rjuju123(at)gmail(dot)com> a
>> écrit :
>>
>>> On Mon, Jan 25, 2021 at 9:34 PM Guillaume Lelarge
>>> <guillaume(at)lelarge(dot)info> wrote:
>>> >
>>> > "Anytime soon" was a long long time ago, and I eventually completely
>>> forgot this, sorry. As nobody worked on it yet, I took a shot at it. See
>>> attached patch.
>>>
>>> Great!
>>>
>>> I didn't reviewed it thoroughly yet, but after a quick look it sounds
>>> sensible. I'd prefer to see some tests added, and it looks like a
>>> test for plpgsql could be added quite easily.
>>>
>>>
>> I tried that all afternoon yesterday, but failed to do so. My had still
>> hurts, but I'll try again though it may take some time.
>>
>>
> s/My had/My head/ ..
>
>
I finally managed to get a working TAP test for my patch. I have no idea if
it's good, and if it's enough. Anyway, new version of the patch attached.

--
Guillaume.

Attachment Content-Type Size
dump_extensions_v2.patch text/x-patch 8.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2021-02-18 10:30:09 Re: Some regular-expression performance hacking
Previous Message Rahila Syed 2021-02-18 10:07:50 Re: a misbehavior of partition row movement (?)