Re: Skip recovery/standby signal files in pg_basebackup

Hi David,

On Sat, Sep 28, 2019 at 12:23 AM David Steele <david(at)pgmasters(dot)net> wrote:
>
> Hackers,
>
> Restoring these files could cause surprising behaviors so it seems best
> to let the restore process create them when needed.
>

Could you please let us know what is the surprising behaviour you are
talking about here when including recovery/standby signal files in
pg_basebackup output.

If including recovery.conf in pg_basebackup output earlier wasn't a
problem then why including recovery/standby.signal should be a
problem.

Your patch is just trying to skip standby.signal or recovery.signal
files when the base backup is either taken on standby server or it is
taken on the server where the PITR is still going on or may be paused.

What would be the behaviour with your patch when *-R* option is used
with pg_basebackup to take backup from standby server ? Won't it
create a standby.signal file.

> Patch is attached.
>

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com