| From: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Hang in pldebugger after git commit : 98a64d0 |
| Date: | 2016-12-17 11:23:09 |
| Message-ID: | CAE9k0Pno6f=gPn57jz3ESscHqzhvV4=BM7WkjAfu39Pik3-AtA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> It is fine as per current usage of WaitEventSet API's, however,
> Robert's point is valid that user is not obliged to call
> ModifyWaitEvent before WaitEventSetWait. Imagine a case where some
> new user of this API is calling WaitEventSetWait repeatedly without
> calling ModifyWaitEvent.
Oops! I never thought this scenario, yes there can be a case where an
external module like FDW may call WaitEventSetWait() and in such case
the fix provided in v1 patch may not work. So, yes we may have to
reset the event in WaitEventSetWaitBlock(). I am extremely extremely
sorry for a noise.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2016-12-17 12:23:54 | Re: Crash on promotion when recovery.conf is renamed |
| Previous Message | Amit Kapila | 2016-12-17 10:51:21 | Re: Hang in pldebugger after git commit : 98a64d0 |