| From: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Page Scan Mode in Hash Index |
| Date: | 2017-09-21 07:08:57 |
| Message-ID: | CAE9k0PnbkFsijZjWRfm=xMgRfEU8TaDWubTyRB4jx0yS1Cn8jw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 21, 2017 at 9:30 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Sep 20, 2017 at 11:43 AM, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
>> Attached are the patches with above changes. Thanks.
>
> Thanks. I think that the comments and README changes in 0003 need
> significantly more work. In several places, they fail to note the
> unlogged vs. logged differences, and the header comment for
> hashbucketcleanup still says that scans depend on increasing-TID order
> (really, 0001 should change that text somehow).
>
I have added a note for handling of logged and unlogged tables in
README file and also corrected the header comment for
hashbucketcleanup(). Please find the attached 0003*.patch having these
changes. Thanks.
--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Rewrite-hash-index-scan-to-work-page-at-a-time_v16.patch | text/x-patch | 32.1 KB |
| 0002-Remove-redundant-hash-function-_hash_step-and-do-som.patch | text/x-patch | 8.5 KB |
| 0003-Improve-locking-startegy-during-VACUUM-in-Hash-Index_v8.patch | text/x-patch | 9.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Emre Hasegeli | 2017-09-21 07:22:46 | Re: close_ps, NULLs, and DirectFunctionCall |
| Previous Message | Haribabu Kommi | 2017-09-21 06:53:43 | Re: Windows warnings from VS 2017 |