Re: Report bytes and transactions actually sent downtream

From: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, michael(at)paquier(dot)xyz, bertranddrouvot(dot)pg(at)gmail(dot)com, andres(at)anarazel(dot)de, shveta(dot)malik(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Report bytes and transactions actually sent downtream
Date: 2026-07-03 05:44:50
Message-ID: CAE9k0PnWMWM7PgcWRwNitcpEDhOnmku2iyrnTDDGbwZ-cL_-4A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Masahiko-san,

On Fri, Jul 3, 2026 at 3:20 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> Could you swap these patches' order? I think that these patches are
> independent of each other and while we have an agreement on the new
> statistics, we still need discussion for the refactoring part
> (particularly I guess it's better to avoid including pgstatt.h in
> reorderbuffer.h)
>

Thank you for your review comments.

I have swapped the patch order - please see attached.

In the refactoring patch, I also ensured that reorderbuffer.h does not
depend on pgstat.h. To make that possible, I introduced a shared
header, src/include/replication/replslot_stats.h, where
PgStat_ReplSlotStats is defined. Both pgstat.h and reorderbuffer.h
include that header. Hope that helps!

--
With Regards,
Ashutosh Sharma.

Attachment Content-Type Size
v20260703-0001-Report-output-bytes-in-pg_stat_replication_slots.patch application/octet-stream 25.4 KB
v20260703-0002-Refactor-replication-slot-decoding-stats-handling.patch application/octet-stream 15.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Roman Khapov 2026-07-03 05:46:55 Re: DROP INVALID INDEXES command
Previous Message Ashutosh Bapat 2026-07-03 05:43:42 Re: (SQL/PGQ) Clean up orphaned properties when dropping a label