| From: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
|---|---|
| To: | Rahila Syed <rahilasyed90(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alexander Kukushkin <cyberdemn(at)gmail(dot)com>, Fabrice Chapuis <fabrice636861(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: issue with synchronized_standby_slots |
| Date: | 2025-09-10 11:22:09 |
| Message-ID: | CAE9k0Pm9BixgN3H+vhnfsj27XkQi1JJ6nqp+rKq9En5o4JS-Rg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 10, 2025 at 3:33 PM Rahila Syed <rahilasyed90(at)gmail(dot)com> wrote:
>
> Hi,
>
>
>> As for the synchronized_standby_slots, we can follow the behavior
>> similar to check_synchronous_standby_names and just give parsing
>> ERRORs. Any non-existent slot related errors can be given when that
>> parameter is later used.
>>
>> --
>
>
> Please find attached a patch that implements this. I will work on adding a test for it.
>
I suggest removing validate_sync_standby_slots() entirely since there
isn’t much left in it.
The below logic currently in validate_sync_standby_slots() to parse
the list of slots can be directly moved into
check_synchronized_standby_slots().
/* Verify syntax and parse string into a list of identifiers */
ok = SplitIdentifierString(rawname, ',', elemlist);
if (!ok)
GUC_check_errdetail("List syntax is invalid.");
--
With Regards,
Ashutosh Sharma.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shlok Kyal | 2025-09-10 11:34:18 | Re: issue with synchronized_standby_slots |
| Previous Message | Alastair Turner | 2025-09-10 11:01:58 | Re: Proposal: Conflict log history table for Logical Replication |