| From: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: PATCH: pageinspect / add page_checksum and bt_page_items(bytea) |
| Date: | 2017-03-14 14:51:07 |
| Message-ID: | CAE9k0PkCnNKTnzWuTPE5BHH1oDRPWVBQdHZenOw04zG1GwPBUw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mar 14, 2017 5:37 PM, "Alvaro Herrera" <alvherre(at)2ndquadrant(dot)com> wrote:
Ashutosh Sharma wrote:
> Yes. But, as i said earlier I am getting negative checksum value for
> page_header as well. Isn't that wrong. For eg. When I debug the
> following query, i could pd_checksum value as '40074' in gdb where
> page_header shows it as '-25462'.
Yes; the point is that this is a pre-existing problem, not one being
introduced with this patch. In SQL we don't have unsigned types, and we
have historically chosen a type with the same width instead of one with
enough width to represent all possible unsigned values. IMO this patch
is doing the right thing; if in the future we want to change that
decision, that's fine but it's a separate patch
Okay, understood . Thank you.
With Regards,
Ashutosh Sharma
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2017-03-14 14:58:54 | Re: WIP: Faster Expression Processing v4 |
| Previous Message | Rahila Syed | 2017-03-14 14:43:47 | Re: wait events for disk I/O |