| From: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
|---|---|
| To: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, MBeena Emerson <mbeena(dot)emerson(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: recovering from "found xmin ... from before relfrozenxid ..." |
| Date: | 2020-07-31 12:52:23 |
| Message-ID: | CAE9k0P=wny32OJH+y9ou8qQw-Q8HvDeXdTp6QiD0wCeq8jnuuQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Attached is the new version of patch that addresses the comments from
Andrey and Beena.
On Wed, Jul 29, 2020 at 10:07 AM Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
wrote:
> Hi Beena,
>
> Thanks for the review.
>
> 1. We would be marking buffer dirty and writing wal even if we have
>> not done any changes( ex if we pass invalid/dead tids). Maybe we can
>> handle this better?
>>
>
> Yeah, we can skip this when nothing has changed. Will take care of it in
> the next version of patch.
>
>
>> cosmetic changes
>> 1. Maybe "HTupleSurgicalOption" instead of "HTupleForceOption" and
>> also the variable names could use surgery instead.
>>
>
> I think that looks fine. I would rather prefer the word "Force" just
> because all the enum options contain the word "Force" in it.
>
>
>> 2. extension comment pg_surgery.control "extension to perform surgery
>> the damaged heap table" -> "extension to perform surgery on the
>> damaged heap table"
>>
>
> Okay, will fix that typo.
>
> --
> With Regards,
> Ashutosh Sharma
> EnterpriseDB:http://www.enterprisedb.com
>
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-contrib-pg_surgery-to-perform-surgery-on-the-dam.patch | text/x-patch | 19.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Henry B Hotz | 2020-07-31 12:53:53 | Re: Is it worth accepting multiple CRLs? |
| Previous Message | Hamid Akhtar | 2020-07-31 12:40:34 | Re: track_planning causing performance regression |