| From: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
|---|---|
| To: | Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com> |
| Cc: | SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Lakshmi N <lakshmin(dot)jhs(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: log XLogPrefetch stats at end of recovery |
| Date: | 2026-10-14 16:05:46 |
| Message-ID: | CAE9k0P=Jv5GsLozhXNcwFnkF+5-D7CenYiGqoja8LM9WUVSa=Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Wed, Oct 14, 2026 at 5:08 PM Jakub Wartak
<jakub(dot)wartak(at)enterprisedb(dot)com> wrote:
>
> On Wed, Oct 14, 2026 at 1:36 PM SATYANARAYANA NARLAPURAM
> <satyanarlapuram(at)gmail(dot)com> wrote:
> >
> >
> >
> > On Thu, Mar 26, 2026 at 5:10 PM Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> >>
> >> Hi,
> >>
> >> On Thu, Mar 26, 2026 at 1:06 AM Lakshmi N <lakshmin(dot)jhs(at)gmail(dot)com> wrote:
> >> >
> >> > Address this in the attached patch. Please let me know if this looks good.
> >> > 2026-03-26 00:51:19.797 PDT [91881] LOG: redo prefetch stats: prefetched 418376 blocks, skipped (362419 in the buffer pool, 418479 zero-initialized, 0 non-existent, 9 full page image, 39183318 recently prefetched)
> >>
> >> Thanks for sending the latest patch. It looks good to me with a
> >> nit:s/362419 in the buffer pool/362419 already in buffer pool. I will
> >> leave it to others' choice
> >
> >
> > LGTM too, I will leave it to the committer's choice.
> >
>
> Hi,
>
> This was never added to the commitfest (even back then) or am I missing
> something?
>
I have created a CF entry for this in the name of Lakshmi N (the
author of this patch). Also, I find that the patch has been idle for
months and no longer applied, so I have rebased it (v4 attached) with
some cosmetic changes.
--
With Regards,
Ashutosh Sharma.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-xlogprefetcher-Log-prefetch-statistics-at-end-of-rec.patch | application/octet-stream | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matheus Alcantara | 2026-10-14 16:12:56 | Re: postgres_fdw: transaction mode inheritance corner cases |
| Previous Message | Heikki Linnakangas | 2026-10-14 15:36:18 | Re: [PATCH] pg_upgrade: handle failed nonblocking connects on Windows |