| From: | Alexandre Felipe <o(dot)alexandre(dot)felipe(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: SLOPE - Planner optimizations on monotonic expressions. |
| Date: | 2026-07-20 19:21:57 |
| Message-ID: | CAE8JnxMkBDm8sKkF=+jt7mo0iUcgqGYwKx5p_dHPGVJ3tE+p=A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jul 19, 2026 at 2:26 PM Alexandre Felipe <
o(dot)alexandre(dot)felipe(at)gmail(dot)com> wrote:
> Thank you for your review Zsolt,
>
> On Fri, Jul 17, 2026 at 10:16 PM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
> wrote:
>
>> - if (enable_slope && index->rel->reloptkind ==
>> RELOPT_BASEREL)
>> + if (enable_slope)
>> {
>> ...
>> - if (cpathkey)
>> - {
>> - /*
>> ...
>
> Isn't that cpathkey if/else needed in the !enable_slope case?
>>
>
> *PENDING*
>
> I thought I was disabling only a piece of code that was added
> on commit 0004.
>
I see it now that I closed the if block in the wrong line hehe.
This also addresses two small issues flagged by CF bot on v11.
enable_slope not in postgresql.conf.sample and a declaration after
code on get_2slope_args.
Regards,
Alexandre
>
| Attachment | Content-Type | Size |
|---|---|---|
| v12-0005-SLOPE-documentation.patch | application/octet-stream | 7.5 KB |
| v12-0002-Optimized-reverse-pathkeys.patch | application/octet-stream | 6.3 KB |
| v12-0004-SLOPE-Planner-support.patch | application/octet-stream | 56.7 KB |
| v12-0001-benchmark.patch | application/octet-stream | 4.8 KB |
| v12-0003-SLOPE-catalog-changes.patch | application/octet-stream | 95.4 KB |
| v12-0006-SLOPE-redundancy-checks.patch | application/octet-stream | 14.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Kirill Reshke | 2026-07-20 19:20:49 | Re: Streaming replication and WAL archive interactions |