Re: amcheck support for BRIN indexes

From: Arseniy Mukhin <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: amcheck support for BRIN indexes
Date: 2025-08-03 14:37:06
Message-ID: CAE7r3MLcV=v-Rr8R1_+aeASSmCprnqw+AEvatKGkKXd2QXhjgQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 1, 2025 at 11:22 PM Arseniy Mukhin
<arseniy(dot)mukhin(dot)dev(at)gmail(dot)com> wrote:
>
> Hi,
>
> On Tue, Jul 22, 2025 at 6:43 PM Arseniy Mukhin
> <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com> wrote:
> >
> > Hi,
> >
> > While reviewing gist amcheck patch [1] I realized that brin amcheck
> > also must check if current snapshot is OK with index indcheckxmin (as
> > btree, gist do it). Currently this check is contained in btree amcheck
> > code, but other AMs need it for heapallindexed as well, so I moved it
> > from btree to verify_common (0003 patch).
>
> There was a compiler warning on CI, so there is a new version with the
> fix (adds #include to verify_common).
> I also moved it to PG19-2.

Sorry for the noise, forgot to attach the files.

Best regards,
Arseniy Mukhin

Attachment Content-Type Size
v9-0001-brin-refactoring.patch text/x-patch 4.1 KB
v9-0004-amcheck-brin_index_check-heap-all-indexed.patch text/x-patch 30.5 KB
v9-0003-amcheck-common_verify-register-snapshot-with-indc.patch text/x-patch 4.1 KB
v9-0002-amcheck-brin_index_check-index-structure-check.patch text/x-patch 46.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Shlok Kyal 2025-08-03 16:07:00 Re: Skipping schema changes in publication
Previous Message Xuneng Zhou 2025-08-03 06:02:54 Re: Bug in pg_dump --filter? - Invalid object types can be misinterpreted as valid