Re: Remove custom redundant full page write description from GIN

On Mon, Oct 13, 2025 at 11:59 PM Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>
>
> On Tue, 14 Oct 2025, 01:24 Arseniy Mukhin, <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com> wrote:
>>
>> Hi,
>>
>> On Fri, Oct 10, 2025 at 10:00 PM Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>> >
>> >
>> >
>> > > On 9 Oct 2025, at 17:33, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>> > >
>> > > Should we remove them, reducing overall cognitive complexity of GIN
>> > > internals and reducing WAL footprint?
>> >
>> > The patch does not add a single line... that's impressive :)
>> >
>> > Why not wipe ginxlogSplit entirely? Will the code be clearer with XLogRegisterData(&flags, sizeof(uint16))?
>> >
>> >
>>
>> Looks like we will not be able to process old split records after
>> this, as 'flags' field offset was changed. So probably these fields
>> are for backward compatibility. Does it make sense?
>>
>>
>> Best regards,
>> Arseniy Mukhin
>
>
> Hi! We do not need to support anything WAL related in new major version, since we do new initdb. There are couple of threads nearby that change WAL record layout or even drop them entirely, and that OK.
> Also, we have WAL magic number for this purpose

I see, sorry for the noise then and thanks for the explanation!

Best regards,
Arseniy Mukhin