| From: | Arseniy Mukhin <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(at)vondra(dot)me> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: amcheck support for BRIN indexes |
| Date: | 2025-07-22 15:43:20 |
| Message-ID: | CAE7r3MJfwYQq9LqVYJDB85XwuXPD1GPsys8HvnqLQT-uB7Z-nw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
While reviewing gist amcheck patch [1] I realized that brin amcheck
also must check if current snapshot is OK with index indcheckxmin (as
btree, gist do it). Currently this check is contained in btree amcheck
code, but other AMs need it for heapallindexed as well, so I moved it
from btree to verify_common (0003 patch).
Also I returned a consistentFn approach in heapallindexed as it seems
more preferable. But it's not a big deal to return to the within_range
approach if needed.
Best regards,
Arseniy Mukhin
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-brin-refactoring.patch | text/x-patch | 4.1 KB |
| v8-0004-amcheck-brin_index_check-heap-all-indexed.patch | text/x-patch | 30.5 KB |
| v8-0002-amcheck-brin_index_check-index-structure-check.patch | text/x-patch | 46.9 KB |
| v8-0003-amcheck-common_verify-register-snapshot-with-indc.patch | text/x-patch | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2025-07-22 15:55:33 | Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions |
| Previous Message | Andrew Dunstan | 2025-07-22 15:26:12 | Re: Proposal: QUALIFY clause |