| From: | Pantelis Theodosiou <ypercube(at)gmail(dot)com> |
|---|---|
| To: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PostgreSQL 12 Beta 1 press release draft |
| Date: | 2019-05-23 15:36:06 |
| Message-ID: | CAE3TBxwvzgvT5SRAAf0vTD2QgCQ4u2iOmZa2_6XE8CoMQfwTzg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 23, 2019 at 1:01 PM Jonathan S. Katz <jkatz(at)postgresql(dot)org>
wrote:
> On 5/23/19 1:45 AM, David Rowley wrote:
> > On Thu, 23 May 2019 at 15:31, Jonathan S. Katz <jkatz(at)postgresql(dot)org>
> wrote:
> >> Attached is
> >> v3 of the patch, along with a diff.
> >
> > Minor details, but this query is not valid:
> >
> >> WITH c AS MATERIALIZED (
> >> SELECT * FROM a WHERE a.x % 4
> >> )
> >> SELECT * FROM c JOIN d ON d.y = a.x;
> >
> > a.x % 4 is not a boolean clause, and "a" is not in the main query, so
> > a.x can't be referenced there.
>
> ...that's the only gotcha I'm actually embarrassed about. Fixed.
>
>
The ON d.y = a.x still needs to be changed to ON d.y = c.x
Pantelis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-05-23 15:46:10 | Re: Memory bug in dsnowball_lexize |
| Previous Message | Mark Dilger | 2019-05-23 15:27:19 | Re: nitpick about poor style in MergeAttributes |