Re: [PATCH] tests: verify renamed index functionality in alter_table

From: VASUKI M <vasukianand0119(at)gmail(dot)com>
To: Dharin Shah <dharinshah95(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] tests: verify renamed index functionality in alter_table
Date: 2026-01-13 07:01:30
Message-ID: CAE2r8H681eL_=sFk=_m+ohDtq0o=gdrNzq4B3hB67qhqRZi+Bg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Dharin,

Thanks for addressing the FIXME in the alter_table regression test.

The change LGTM. Verifying both planner visibility via EXPLAIN and runtime
correctness with a SELECT after the index rename is a solid improvement,
and using the standard enable_seqscan/bitmapscan/indexonlyscan = off
pattern keeps the test deterministic.

I tested the patch locally and it passes:

make check TESTS=alter_table

full make check

O/P: ok 206 + alter_table 870 ms

I don’t see any issues with the approach.

Regards,
Vasuki M,
C-DAC,Chennai

>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-01-13 07:09:46 Re: JumbleQuery ma treat different GROUP BY expr as the same
Previous Message Chao Li 2026-01-13 06:31:55 Re: Correct comment wording in extension.c