| From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] [PATCH] Improve geometric types |
| Date: | 2018-02-01 09:36:41 |
| Message-ID: | CAE2gYzzRW_P=3hMn3zwUq90fsaQRD5b8Fy3dpOa3h2vTfuaTwQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> ! circle_contain_pt() does the following comparison and it
> seems to be out of our current policy.
>
> point_dt(center, point) <= radius
>
> I suppose this should use FPle.
>
> FPle(point_dt(center, point), radius)
>
> The same is true of circle_contain_pt(), pt_contained_circle .
box_contain_point() also doesn't use the macros. They are certainly
inconsistent, but I don't think it would be an improvement to make
them use the macros. As we have discussed, there are many problems
with the current application of EPSILON. I think we would be better
off not using the macros for none of the containment operators, but
this is out of my scope for now.
> # Sorry, that' all for today..
I am waiting the rest of your review to post the new versions.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-02-01 09:42:40 | Re: no partition pruning when partitioning using array type |
| Previous Message | Emre Hasegeli | 2018-02-01 09:35:42 | Re: [HACKERS] [PATCH] Improve geometric types |