From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andreas Karlsson <andreas(at)proxel(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Florian Pflug <fgp(at)phlo(dot)org>, Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: GiST support for inet datatypes |
Date: | 2014-04-09 16:43:23 |
Message-ID: | CAE2gYzz-0SO_yNWz1EyF_j3=M_RS8acz+6PzYg8dddKaY3=uJg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> Committed with some additional documentation work. Thanks for
> submitting this!
Thank you for committing. I had not thought of using different structure
for the index. It works faster with my test case, too.
I am sending rebased version of the consistent operator names patch
in case you would like to include it to the same release. This is what
I wrote about this change before:
> That is why I prepared it as a separate patch on top of the others. It is
> not only consistency with the range types: <@ and @> symbols used for
> containment everywhere except the inet data types, particularly on
> the geometric types, arrays; cube, hstore, intaray, ltree extensions.
> The patch does not just change the operator names, it leaves the old ones,
> adds new operators with GiST support and changes the documentation, like
> your commit ba920e1c9182eac55d5f1327ab0d29b721154277 back in 2006. I could
> not find why did you leave the inet operators unchanged on that commit,
> in the mailing list archives [1]. GiST support will be a promotion for
> users to switch to the new operators, if we make this change with it.
>
> This change will also indirectly deprecate the undocumented non-transparent
> btree index support that works sometimes for some of the subnet inclusion
> operators [2].
>
> [1] http://www.postgresql.org/message-id/14277.1157304939@sss.pgh.pa.us
>
> [2] http://www.postgresql.org/message-id/389.1042992616@sss.pgh.pa.us
Attachment | Content-Type | Size |
---|---|---|
inet-operator-v2.patch | application/octet-stream | 12.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2014-04-09 16:51:43 | Re: default opclass for jsonb (was Re: Call for GIST/GIN/SP-GIST opclass documentation) |
Previous Message | Tom Lane | 2014-04-09 16:20:53 | Re: Autonomous Transaction (WIP) |