| From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Subject: | Re: [PATCH] Improve geometric types |
| Date: | 2018-06-05 16:32:59 |
| Message-ID: | CAE2gYzyM=xKr-AoBakj1GHh_1Vv9iQ+KqKsdMvckiZ2GbV4ZfQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Those underscore-prefixed names are defined in Microsoft's
> <float.h>[3][4]. So now I'm wondering if win32_port.h needs to
> #include <float.h> if (_MSC_VER < 1800).
I don't have the C experience to decide the correct way. There are
currently many .c files that are including float.h conditionally or
unconditionally. The condition they use is "#ifdef _MSC_VER" without
a version.
One idea is to include float.h from the new utils/float.h file
together with math.h, and remove those includes from the .c files
which would include utils/float.h. We can do this only, or together
with what you suggest, or by also keeping the includes on the .c
files. Which way do you think is the proper?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | MauMau | 2018-06-05 16:34:20 | Re: I'd like to discuss scaleout at PGCon |
| Previous Message | Tom Lane | 2018-06-05 16:32:25 | Re: Code of Conduct plan |