| From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] [PATCH] Improve geometric types |
| Date: | 2018-01-19 09:38:07 |
| Message-ID: | CAE2gYzy0ZW4CJjhEo5A+ywXhJom3NuKtGwaMQpLqM-STFxh8Ew@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I'm fine with the current shape. Thanks. Maybe the same
> discussion applies to polygons. (cf. poly_overlap)
It indeed does. I am incorporating.
> line_closept_point asserts line_interpt_line returns true but it
> is hazardous. It is safer if line_closept_point returns NaN if
> line_interpt_line returns false.
Yes, it makes more sense. I am changing it.
>> > I understand that we don't need to consider NAN is equal to NAN.
>> > circle_same, point_eq_point, line_eq no longer needs such
>> > change?
>>
>> I though it would be better to consider NaNs equal only on the
>> equality operators. That is why only they are changed that way.
>
> I'm convinced by that.
Great. I am documenting this decision better on the patches.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Khandekar | 2018-01-19 09:50:23 | Re: [HACKERS] Useless code in ExecInitModifyTable |
| Previous Message | Amit Khandekar | 2018-01-19 09:37:14 | Re: [HACKERS] UPDATE of partition key |