Re: [PATCH] Improve geometric types

From: Emre Hasegeli <emre(at)hasegeli(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Improve geometric types
Date: 2018-07-30 09:57:38
Message-ID: CAE2gYzxgMr8=rMqpm1srd1id6PcSpuD=LinD5aVmoY7XejKaGw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> OK, thanks for confirming. I'll get it committed and we'll see what the
> animals think soon.

Thank you for fixing this. I wanted to preserve this code but wasn't
sure about the correct place or whether it is still necessary.

There are more places we produce -0. The regression tests have
alternative results to cover them. I have the "float-zero" patch for
this. Although I am not sure if it is a correct fix. I think we
should find the correct fix, and apply it globally to floating point
operations. This can be only enabled for platforms which produce -0,
so the others don't have to pay the price.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-07-30 10:20:45 Re: [PATCH] Include application_name in "connection authorized" log message
Previous Message Kyotaro HORIGUCHI 2018-07-30 09:48:13 Re: patch to allow disable of WAL recycling