| From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BRIN range operator class |
| Date: | 2015-05-05 09:57:40 |
| Message-ID: | CAE2gYzwsbqVbjSHVMrvwEx-iSE3naENkq9DAED3oSvzViRfsag@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> From my point of view as a reviewer this patch set is very close to being
> committable.
Thank you. The new versions are attached.
> - "operator classes store the union of the values in the indexed column" is
> not technically true. It stores something which covers all of the values.
I rephrased it as " operator classes store a value which includes the
values in the indexed column".
> - Missing space in "except box and point*/".
Fixed.
> = brin-inclusion-v06-07-remove-minmax-amprocs.patch
>
> Shouldn't this be merged with 02? Otherwise it looks good.
It doesn't have any relation with the 02-strategy-numbers.patch.
Maybe you mean 01-sql-level-support-functions.patch and
05-box-vs-point-operators.patch should be merged. They can always be
committed together.
| Attachment | Content-Type | Size |
|---|---|---|
| brin-inclusion-v07-01-sql-level-support-functions.patch | application/octet-stream | 37.9 KB |
| brin-inclusion-v07-02-strategy-numbers.patch | application/octet-stream | 4.5 KB |
| brin-inclusion-v07-03-remove-assert-checking.patch | application/octet-stream | 4.2 KB |
| brin-inclusion-v07-04-fix-brin-deform-tuple.patch | application/octet-stream | 2.3 KB |
| brin-inclusion-v07-05-box-vs-point-operators.patch | application/octet-stream | 19.6 KB |
| brin-inclusion-v07-06-inclusion-opclasses.patch | application/octet-stream | 80.9 KB |
| brin-inclusion-v07-07-remove-minmax-amprocs.patch | application/octet-stream | 34.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Emre Hasegeli | 2015-05-05 10:06:37 | Re: BRIN range operator class |
| Previous Message | Andreas Karlsson | 2015-05-05 09:33:28 | Re: BRIN range operator class |