| From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Ning Yu <nyu(at)pivotal(dot)io>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New Defects reported by Coverity Scan for PostgreSQL |
| Date: | 2018-08-01 09:55:53 |
| Message-ID: | CAE2gYzw6iD1YTZ+67hA=s3AG5sbLCsGkHRYQ_Z1Kd+vhiM7ecA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
> Or perhaps I have it backwards and "l1" and "l2" need to be swapped in
> that description. But the mere fact that there is any question about
> that means that the function is poorly documented and perhaps poorly
> named as well. For that matter, is there a good reason why l1/l2
> have those roles and not the reverse?
Consistency. I organized all xxx_closept_yyy(Point *result, xxx *l1,
yyy *l2) functions in a way that they find the find the point on "l1".
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-08-01 12:15:27 | pgsql: Update parallel.sgml for Parallel Append |
| Previous Message | Tomas Vondra | 2018-08-01 09:23:16 | Re: New Defects reported by Coverity Scan for PostgreSQL |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sergei Kornilov | 2018-08-01 10:16:58 | Re: Online enabling of checksums |
| Previous Message | Tomas Vondra | 2018-08-01 09:23:16 | Re: New Defects reported by Coverity Scan for PostgreSQL |