Re: Make pg_basebackup -x stream the default

From: Vladimir Rusinov <vrusinov(at)google(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Make pg_basebackup -x stream the default
Date: 2016-12-19 10:51:04
Message-ID: CAE1wr-zdnYm3ZVsBA90pc-T-DZv7jnuSDST20Y44evgG1qudpQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 17, 2016 at 2:37 PM, Magnus Hagander <magnus(at)hagander(dot)net>
wrote:

> Attached is an updated patch that does this. As a bonus it simplifies the
> code a bit. I also fixed an error message that I missed updating in the
> previous patch.

looks good to me.

Still applies cleanly at head with all tests pass.
I have no further comments, although since I'm not experienced Postgres
reviewer, commiter may want to take another look before merging.

--
Vladimir Rusinov
Storage SRE, Google Ireland

Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2016-12-19 11:13:19 Re: Measuring replay lag
Previous Message Simon Riggs 2016-12-19 09:46:16 Re: Measuring replay lag