Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal

From: Vladimir Rusinov <vrusinov(at)google(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, David Steele <david(at)pgmasters(dot)net>, Cynthia Shang <cynthia(dot)shang(at)crunchydata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal
Date: 2017-01-11 17:00:29
Views: Raw Message | Whole Thread | Download mbox
Lists: pgsql-hackers

On Tue, Jan 10, 2017 at 5:24 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>

> - errhint("pg_xlogfile_name_offset() cannot be executed
> during recovery.")));
> + errhint(
> + "pg_wal_file_name_offset() cannot be executed
> during recovery.")));
> I am not sure that there is any need to reformat this error hint.
> Your patch includes useless diff noise in pg_proc.h. By that I mean
> the lines of pg_start_backup, pg_stop_backup, etc.
> +/* Next OID: 6016 */
> +
> I don't think you need that.

Reverted all of above.

> src/test/perl/ has added recently a new method called
> lsn() that uses some of the WAL position functions. Their update is
> necessary as well for this patch.

Good catch. Changed those as well.

> As there are two school of thoughts on this thread, keeping your patch
> with the compatibility table is the best move for now. Even if we end
> up by having a version without aliases, that will be just code to
> remove in the final version.

Indeed, it is trivial to kill aliases.

New version of the patch attached.

Vladimir Rusinov
Storage SRE, Google Ireland

Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047

Attachment Content-Type Size
0004-Remove-xlog-references-from-admin-functions.patch text/x-patch 67.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-01-11 17:02:46 Re: [HACKERS] Questionable tag usage
Previous Message Peter Eisentraut 2017-01-11 16:55:15 Re: [HACKERS] Questionable tag usage