From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Vladimir Rusinov <vrusinov(at)google(dot)com> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, David Steele <david(at)pgmasters(dot)net>, Cynthia Shang <cynthia(dot)shang(at)crunchydata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal |
Date: | 2017-01-12 05:49:22 |
Message-ID: | CAB7nPqR2=jdoBApHOEMyPPfyyJrg1rFiug3TDc-U-C1zM2GC+g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jan 12, 2017 at 2:00 AM, Vladimir Rusinov <vrusinov(at)google(dot)com> wrote:
> On Tue, Jan 10, 2017 at 5:24 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
> wrote:
>> As there are two school of thoughts on this thread, keeping your patch
>> with the compatibility table is the best move for now. Even if we end
>> up by having a version without aliases, that will be just code to
>> remove in the final version.
>
> Indeed, it is trivial to kill aliases.
>
> New version of the patch attached.
The patch still updates a bunch of .po files. Those are normally
refreshed with the translation updates, so they had better be removed.
Other than that, the patch looks in good shape to me so switch to
"Ready for committer".
So, to sum up things on this thread, here are the votes about the use
of aliases or a pure breakage:
- No to aliases, shake the world: Stephen, Tom, David F, Vik, Bruce M => 5
- Yes to aliases: Michael P, Andres, Peter E., Cynthia S, Jim N,
Vladimir, Simon R, Fujii-san => 8
If I misunderstood things, please feel free to speak up.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2017-01-12 05:56:10 | Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal |
Previous Message | Andrew Borodin | 2017-01-12 05:45:49 | Re: background sessions |