| From: | Mark Dilger <hornschnorter(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | WIP patch for Oid formatting in printf/elog strings |
| Date: | 2014-12-11 17:31:26 |
| Message-ID: | CAE-h2TrbiH2e_NQJGBMzQ9Eg24i6pkSsa4E2YKWqjWz2PNru2A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I found a few places in the code where a variable of
type Oid is printed using "%d" rather than "%u" and
changed them in the attached patch.
In src/backend/replication/logical/reorderbuffer.c,
circa line 2494, chunk_seq is of type Oid, but
ent->last_chunk_seq is of type int32, leading me
to question if perhaps the use of %d for chunk_seq
is correct, but the use of Oid for the type of chunk_seq
is in error. If neither is in error, perhaps someone
can provide a short code comment explaining the
logic of the signed/unsigned discrepancy.
Thanks,
Mark Dilger
| Attachment | Content-Type | Size |
|---|---|---|
| oidformat.diff | text/plain | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2014-12-11 17:39:48 | Re: WIP patch for Oid formatting in printf/elog strings |
| Previous Message | Kevin Grittner | 2014-12-11 17:29:05 | Re: PATCH: hashjoin - gracefully increasing NTUP_PER_BUCKET instead of batching |