| From: | Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com> |
|---|---|
| To: | Hannu Krosing <hannuk(at)google(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipkumarb(at)google(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
| Subject: | Re: making tid and HOTness of UPDATE available to logical decoding plugins |
| Date: | 2025-12-04 22:35:00 |
| Message-ID: | CADzfLwVqazjsPHgxuadvX0eW3MpByfRy9J4DWJ9goakp+G_sEA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello!
Thanks for the patch.
Few comments:
1) tests are failing, expected output files need to be updated
2)
> * Treat HOT update as normal updates. There is no useful
> * information in the fact that we could make it a HOT update
> * locally and the WAL layout is compatible.
I think it feels a little bit irrelevant now. Also, I'll prefer to
give XLOG_HEAP_HOT_UPDATE a dedicated case switch.
3) _format_tid - not sure _ prefix is a good idea here, but not sure.
4) new double newlines before and after _format_tid
5)
> if (change->data.tp.newctid.ip_posid)
Should we change it to
if (ItemPointerIsValid(&change->data.tp.newctid))
Best regards,
Mikhail.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2025-12-04 22:52:35 | Re: More const-marking cleanup |
| Previous Message | Paul A Jungwirth | 2025-12-04 22:34:17 | Fix out-of-date comment on makeRangeConstructors |