Hello, Miłosz!
> Any thoughts on moving the 'idxRel->rd_index->indisvalid' check into 'IsIndexUsableForReplicaIdentityFull()' itself?
I initially thought about that approach too, but an assertion also
uses that check.
This is explained in the commit message:
> Skip invalid indexes, as the planner does. The test belongs here rather
> than in IsIndexUsableForReplicaIdentityFull(), whose other caller is an
> assertion that would then trip over an index DROP INDEX CONCURRENTLY has
> just invalidated but that still finds tuples fine.
Regards,
Mikhail