Re: Tab completion for TABLESAMPLE

From: Brendan Jurd <direvus(at)gmail(dot)com>
To: Petr Jelinek <petr(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Tab completion for TABLESAMPLE
Date: 2015-06-19 20:01:52
Message-ID: CADxJZo0CN_Yno8s9sc0CE6RZDYUabmK8gG=6tOP233vwDGwcxA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 19 Jun 2015 at 21:05 Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:

> On 2015-06-19 09:08, Brendan Jurd wrote:
> > I
> > think it would be convenient and user-friendly to complete the opening
> > bracket -- it would make it perfectly clear that an argument is required
> > for the syntax to be valid.
> >
>
> Agreed, here is updated version which does that.
>

Thanks Petr, I have tested your v2 and it works well. This is ready for
committer.

Cheers,
BJ

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2015-06-19 20:39:06 Re: pretty bad n_distinct estimate, causing HashAgg OOM on TPC-H
Previous Message Jeff Janes 2015-06-19 19:48:36 Re: pretty bad n_distinct estimate, causing HashAgg OOM on TPC-H