| From: | Nishant Sharma <nishant(dot)sharma(at)enterprisedb(dot)com> |
|---|---|
| To: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
| Cc: | Manni Wood <manni(dot)wood(at)enterprisedb(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement |
| Date: | 2025-11-10 09:27:27 |
| Message-ID: | CADrsxdYx1b4XTdjuuB1FeMsrzBZR8s_00gBzW8VmDBxYQJF3CA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
1. I have moved our build_tablespace_ddl_string in pg_tablespace.c
2. Removed unnecessary includes in new file pg_tablespace.c
3. Added 'or oid' as type in doc file for documentation along with name.
4. Added 'pg_tablespace.c' in the meson build file.
The problem appears to be with meson build (also suggested by Jim):
https://cirrus-ci.com/task/5376297293053952
Hopefully this resolves the CI issue.
PFA, v10 patch set.
Regards,
Nishant Sharma.
EDB, Pune.
https://www.enterprisedb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0002-Adds-pg_get_tablespace_ddl-function.patch | application/octet-stream | 15.6 KB |
| v10-0001-Supporting-changes-for-pg_get_tablespace_ddl-fun.patch | application/octet-stream | 7.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2025-11-10 09:28:06 | Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments |
| Previous Message | Dean Rasheed | 2025-11-10 09:21:29 | Re: ON CONFLICT DO SELECT (take 3) |