| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, Erik Rijkers <er(at)xs4all(dot)nl>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |
| Date: | 2017-02-13 20:18:38 |
| Message-ID: | CADkLM=dKXVHn2pCx-JZqbsXb-fT7nn5LLebxTkmd3XPe4ayBdg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 13, 2017 at 3:04 PM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>
> Hello Corey,
>
> That effort was creating as many headaches as it solved. Rolled back v12
>> except for doc paragraph, added more descriptive tap test names. Enjoy.
>>
>
> The TAP tests are missing from the patch, not sure why...
>
I went back to master and re-applied v11, something must have gotten lost
in translation.
> The stack cleanup is nicer with pop calls.
>
Yeah, dunno why I didn't do that earlier.
> Two debatable suggestions about the example:
> - put the on_error_stop as the very first thing in the example?
> - add a comment explaining what the SELECT ... \gset does?
Both are reasonable and easy. Added.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001.if_endif.v14.diff | text/plain | 26.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-02-13 20:21:22 | Re: Small improvement to parallel query docs |
| Previous Message | Robert Haas | 2017-02-13 20:08:14 | Re: Removal of deprecated views pg_user, pg_group, pg_shadow |