Re: Add starelid, attnum to pg_stats and leverage this in pg_dump

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Sami Imseih <samimseih(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
Date: 2026-03-12 20:16:31
Message-ID: CADkLM=d-yUR8JsM-UmCfeRAhVj+X9MYi0kz9=zQO4EoBkd8H8A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 10, 2026 at 12:42 PM Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
wrote:

>
>
> On Tue, Mar 10, 2026 at 12:37 PM Nathan Bossart <nathandbossart(at)gmail(dot)com>
> wrote:
>
>> On Mon, Mar 09, 2026 at 06:42:46PM -0400, Corey Huinker wrote:
>> > If you want 0003 split into two (one for pg_stats_ext and one for
>> > pg_stats_ext_exprs) I can do that, but they felt like a package deal to
>> me.
>>
>> Sorry to throw a curveball here, but I think the best way to structure
>> this
>> patch set is as follows:
>>
>> * 0001: Just the test changes (e.g., replacing * with column lists). By
>> doing that first, the actual functionality changes in 0002 will be easier
>> to see.
>>
>
> Makes sense.
>
>
>>
>> * 0002: Adding columns to the all the views (this one will do a catalog
>> bump). If we need to make a couple of test adjustments to verify the OIDs
>> or attribute IDs, that's fine, but those can be pretty minimal.
>>
>
> So all three views in one go. +1
>
>
>>
>> * 0003: Associated pg_dump changes.
>>
>
> On it.
>

Apologies for the delay. I thought I had posted this. I rebased it
against a630ac5c2016e52 (current HEAD).

Attachment Content-Type Size
v5-0001-Add-test-view-pg_stats_check.patch text/x-patch 13.9 KB
v5-0002-Add-tableid-statid-attnum-expr_attnum-columns-to-.patch text/x-patch 77.9 KB
v5-0003-pg_dump-Use-tableid-in-getAttributeStats.patch text/x-patch 8.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vinod Sridharan 2026-03-12 20:26:14 Add a check for interrupts in ginInsert
Previous Message Sami Imseih 2026-03-12 20:16:29 pg_plan_advice: rtekind uninitialized compilation waning