| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add starelid, attnum to pg_stats and leverage this in pg_dump |
| Date: | 2026-03-12 21:08:34 |
| Message-ID: | CAA5RZ0tiL01rYm7=WaDGLUYjvz+fQRqmaXyRUv9jKRnR3_6xDQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Apologies for the delay. I thought I had posted this. I rebased it against a630ac5c2016e52 (current HEAD).
Thanks!
just a few things.
v5-0001:
+-- Set up convenience views
+--
+CREATE VIEW stats_import.pg_stats_check AS
It will be good to add more commentary here to the next person adding
a test, and mention
that only stable values should be included in this view. what do you think?
v5-0002:
This is the wrong link. It should be catalog-pg-attribute and not
catalog-pg-class
+ (references <link
linkend="catalog-pg-class"><structname>pg_attribute</structname></link>.<structfield>attrelid</structfield>)
and a few occurrences where the link to pg_statistic_ext is pointing
to catalog-pg-class:
+ (references <link
linkend="catalog-pg-class"><structname>pg_statistic_ext</structname></link>.<structfield>stxrelid</structfield>)
v5-0003:
LGTM
--
Sami Imseih
Amazon Web Services (AWS)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Burd | 2026-03-12 21:19:13 | Re: Areas for Solaris support modernization |
| Previous Message | Sami Imseih | 2026-03-12 20:39:04 | Re: Add missing stats_reset column to pg_stat_database_conflicts view |