| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Common function for percent placeholder replacement |
| Date: | 2022-12-20 21:32:45 |
| Message-ID: | CADkLM=f_nvLgYF1zAchqE90uYwM2cWrYmp6OB0VXWy+75HSFdw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> How about this new one with variable arguments?
I like this a lot, but I also see merit in Alvaro's PERCENT_OPT variadic,
which at least avoids the two lists getting out of sync.
Initially, I was going to ask that we have shell-quote-safe equivalents of
whatever fixed parameters we baked in, but this allows the caller to do
that as needed. It seems we could now just copy quote_identifier and strip
out the keyword checks to get the desired effect. Has anyone else had a
need for quote-safe args in the shell commands?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-12-20 21:41:54 | Re: Minimal logical decoding on standbys |
| Previous Message | David Rowley | 2022-12-20 21:05:05 | Re: appendBinaryStringInfo stuff |