| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Can we remove support for standard_conforming_strings = off yet? |
| Date: | 2026-01-02 22:20:30 |
| Message-ID: | CADkLM=fEZWrZkb2PgaB=tSHGqLhTkzmgge3+0czSqyj6Q_Un-A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> I don't see this as a big issue, unless I'm misunderstanding.
>
> Personally I would call it a deal-breaker if I thought it'd affect
> more than a very very tiny number of people. But the entire premise
> of this patch is that nobody is using standard_conforming_strings =
> off in production anymore. If that isn't true it's probably a
> mistake to go forward anyway.
>
>
>
>
> I think you're probably right that very few people are using it. Not sure
> how we'd find out if they are, though.
>
I've poked around for a while now, and I can't find anything that should
have been removed that wasn't already removed.
I'm a teensy bit uneasy that we're outright removing escape_string_warning,
perhaps allowing it to be set but not actually setting the GUC might allow
some ancient script to avoid an error, but that unease isn't enough to stop
anything.
I do think we should make an effort in the release notes to say that
db-dumps with standard_conforming_strings = off must first be restored to a
pre-19 instance before upgrading, but that's about it.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2026-01-02 22:53:56 | Re: Implement waiting for wal lsn replay: reloaded |
| Previous Message | Tom Lane | 2026-01-02 21:35:39 | Re: planner makes provably suboptimal index selection choices with partial indexes |