Re: vacuumdb: add --dry-run

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: vacuumdb: add --dry-run
Date: 2025-12-04 23:40:42
Message-ID: CADkLM=ey_tb1i8x5bpZgT86MGVyVVcU9ZG8-DMA-zSJxgWU7Kg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> Yeah, I'm finding myself liking the idea of moving all of these things into
> vacuumingOptions so that we don't have to cart around so many bool
> arguments. Here's a new patch set that does it this way.
>

+1. Every time I modify a global variable, I hear my high school CS teacher
scolding me.

> The remaining question in my mind is where we should let the user know that
> we're in dry-run mode. The three options I see are 1) at the beginning of
> vacuumdb execution, 2) in the !quiet block for each database, and 3) in
> each command (via a comment). In v5, I've added a message to all three,
> but I'm eager to hear what folks think.
>

Looking at them, I think they're all good. I think #3 is a must-have in all
circumstances. I wouldn't be mad if we removed #1 or #2, but I see the
value in each of them.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mihail Nikalayeu 2025-12-05 00:03:00 Re: Adding REPACK [concurrently]
Previous Message Michael Paquier 2025-12-04 23:14:58 Re: [Proposal] Adding callback support for custom statistics kinds