Re: vacuumdb: add --dry-run

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: vacuumdb: add --dry-run
Date: 2025-11-20 22:09:54
Message-ID: CADkLM=ejhuvk9TOmYe09kaWdUoCzPci1aYa9+ADOwzP22e1XeA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 20, 2025 at 4:46 PM Nathan Bossart <nathandbossart(at)gmail(dot)com>
wrote:

> On Wed, Nov 19, 2025 at 07:54:06PM -0500, Corey Huinker wrote:
> > Here's a shopping list of incremental changes. I'm happy with whatever
> > makes the most sense to you.
>
> Here is a v4 patch set. I've made a variety of small changes. I think
> there's some room to bike-shed on the messages we send to the user to
> assure them we're not actually doing anything, but this is roughly what I
> imagined.
>

Everything here looks good to me. I have nothing to add.

I have no objections to, but I am curious about the factors that went into
making dry_run an independent boolean rather than part of vacopts.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2025-11-20 22:11:34 Re: Checkpointer write combining
Previous Message Masahiko Sawada 2025-11-20 22:08:37 Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE