| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add SHELL_EXIT_CODE to psql |
| Date: | 2023-03-24 21:21:27 |
| Message-ID: | CADkLM=eSKwRGF-rnRqhtBORRtL49QsjcVUCa-kLxKTqxypsakw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 21, 2023 at 3:33 PM Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
wrote:
>
>> As you had it, any nonzero result would prevent backtick substitution.
>> I'm not really sure how much thought went into the existing behavior,
>> but I am pretty sure that it's not part of this patch's charter to
>> change that.
>>
>> regards, tom lane
>>
>
> The changes all make sense, thanks!
>
This is a follow up patch to apply the committed pattern to the various
piped output commands.
I spotted this oversight in the
https://www.postgresql.org/message-id/CADkLM=dMG6AAWfeKvGnKOzz1O7ZNctFR1BzAA3K7-+XQxff=4Q@mail.gmail.com
thread and, whether or not that feature gets in, we should probably apply
it to output pipes as well.
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Have-pipes-set-SHELL_ERROR-and-SHELL_EXIT_CODE.patch | text/x-patch | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2023-03-24 21:27:53 | Re: Should we remove vacuum_defer_cleanup_age? |
| Previous Message | Daniel Gustafsson | 2023-03-24 21:12:13 | Re: Refactoring SysCacheGetAttr to know when attr cannot be NULL |