Re: Import Statistics in postgres_fdw before resorting to sampling.

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org, jkatz(at)postgresql(dot)org, nathandbossart(at)gmail(dot)com
Subject: Re: Import Statistics in postgres_fdw before resorting to sampling.
Date: 2026-05-26 20:31:47
Message-ID: CADkLM=eD13q2PCj4jBLEkXjFnRcweEX5QNSu8un2dTbMX9UQdg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, May 16, 2026 at 5:10 AM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
wrote:

> On Thu, May 14, 2026 at 8:35 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
> wrote:
> > I'll push the updated patch if no objections from you (or anyone else).
>
> Pushed. I closed the open item as well.
>
> Best regards,
> Etsuro Fujita
>

My own apologies for a late reply. I agree that the second method was the
better fix, and I agree with your changes (making free_remattrmap tolerant
of null maps, and moving the if-tests to asserts).

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2026-05-26 20:32:47 Re: First draft of PG 19 release notes
Previous Message Bertrand Drouvot 2026-05-26 20:18:50 Re: Avoid orphaned objects dependencies, take 3