| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Yuefei Shi <shiyuefei1004(at)gmail(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Tomas Vondra <tomas(at)vondra(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Subject: | Re: Extended Statistics set/restore/clear functions. |
| Date: | 2025-11-21 22:41:15 |
| Message-ID: | CADkLM=dwpSPt6yJfcBoZ_GGyVFZ4D5GCTsw3q8dTG+FVgMd8iA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
>
> A few small comments.
>
> 1. Minor typo fixes:
>
+1 Thanks.
> 2.Code maintainability suggestion:
> I noticed the string "malformed pg_dependencies: "%s"" is used repeatedly
> throughout the code. Would you consider defining this as a macro? This
> could reduce duplication and make future updates easier.
>
It seems to be the way of things. As I stated earlier, what I'd really like
is the ability to form different errdetails and have them feed into one
errsave(), and still have the strings go through translation.
>
> 3.Memory management observation:
> Regarding item_attnum_list, while PostgreSQL's memory context mechanism
> handles cleanup, explicitly freeing the allocated memory after use might
> improve code clarity.
>
> These are all minor points - the implementation looks solid overall. Thank
> you for your work on this feature!
>
+1
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2025-11-21 22:57:26 | Re: RFC 9266: Channel Bindings for TLS 1.3 support |
| Previous Message | Andres Freund | 2025-11-21 22:38:52 | Re: index prefetching |