Re: Several issues with postgres_fdw stats import

>
>
> No, it won't fall back; the syntax error on the remote server will
> lead to an error on the local server, actually. That isn't great, so
> I modified postgres_fdw to do the fallback. Patch attached.
>

My mistake. The patch looks good. Clearly there's no sufficiently venerable
buildfarm animal that could have detected this, or else we would have found
it sooner, and it's hard to justify supporting it if we cant test it.

>
> > The obvious counter-example are databases that are forks of postgres
> from the 8.x era (Vertica, Redshift), neither of which have a pg_stats
> view, so the queries are dead ends anyway. I could envision a future where
> those databases are encouraged to add a pg_stats view with the stats
> translated/synthesized to FDW-friendly values.
>
> Me too.
>

It's a bummer that this change will make it slightly harder to do so, but
the chance of redshift or vertica doing such a thing is very low, and if
they did they'd probably bump their server_version_number along with the
change.

> e user trusts the remote to have good stats, otherwise they wouldn't use
> this option.
>
> I modified postgres-fdw.sgml as well to mention that that option is
> ignored, tweaking a phrase a bit.
>
>
+1. Applies clean. Passes tests tho obviously the test we needed all along
would have been on a very old buildfarm animal. The wording of the
documentation change is clear.