| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org, jkatz(at)postgresql(dot)org, nathandbossart(at)gmail(dot)com |
| Subject: | Re: Import Statistics in postgres_fdw before resorting to sampling. |
| Date: | 2026-03-30 20:05:43 |
| Message-ID: | CADkLM=dSX5F5BXfSL8WNiV1OB06q0r_DcAWsvchWfPDp+hdzBw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> You forgot to pass the res to pgfdw_report_error for proper logging.
> I fixed this in the patch I posted just before.
>
+1
>
> > I've update the logic that we don't try to fetch attrstats if the
> reltuples is 0 or -1, and though the comments still mention the difference
> in server version, the code behaves the same in new versions and old. My
> thinking is that either value means "you are not going to find attstats"
> and our reaction is the same either way.
>
Agree.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2026-03-30 20:14:25 | Re: [BUG] Excessive memory usage with update on STORED generated columns. |
| Previous Message | Corey Huinker | 2026-03-30 20:04:46 | Re: Import Statistics in postgres_fdw before resorting to sampling. |