Re: Extended Statistics set/restore/clear functions.

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us
Subject: Re: Extended Statistics set/restore/clear functions.
Date: 2025-11-18 02:34:14
Message-ID: CADkLM=ctsYGwHin8TtU2dmbLmssNCyAcmStfx1yKbMKrUSMNCg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 17, 2025 at 6:35 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> On Mon, Nov 17, 2025 at 08:53:35PM +0800, jian he wrote:
> > segfault:
> > SELECT '[{"attributes" : [1,2,3,4,5,67,6,7,8], "ndistinct" :
> 4}]'::pg_ndistinct;
> >
> > because src/backend/statistics/mvdistinct.c line: 310, Assert
> > Assert((item->nattributes >= 2) && (item->nattributes <=
> STATS_MAX_DIMENSIONS));
>
> Ahah, good one here. Perhaps we had better switch this assertion to
> become an elog() with the import functions in mind, as well. It may
> be worth double-checking the other deserialization paths, as well. We
> need to be super careful about this stuff for data imports.
>

Yeah, I liked that one too, and I can act on that while we're debating how
tightly to turn the screws on combinatorics.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message cca5507 2025-11-18 02:47:20 Re: minor improvement in snapbuild: use existing interface and removefake code
Previous Message Tatsuo Ishii 2025-11-18 02:33:20 Re: Row pattern recognition