Re: simplifying foreign key/RI checks

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: simplifying foreign key/RI checks
Date: 2021-01-19 17:55:10
Message-ID: CADkLM=cFjr1CWp_6u-4wwMd_XN1AEtEASijZRfKxVFj3F4AGQg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> I decided not to deviate from pk_ terminology so that the new code
> doesn't look too different from the other code in the file. Although,
> I guess we can at least call the main function
> ri_ReferencedKeyExists() instead of ri_PrimaryKeyExists(), so I've
> changed that.
>

I agree with leaving the existing terminology where it is for this patch.
Changing the function name is probably enough to alert the reader that the
things that are called pks may not be precisely that.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message James Hilliard 2021-01-19 17:55:46 Re: [PATCH v2 1/1] Fix detection of pwritev support for OSX.
Previous Message Tom Lane 2021-01-19 17:50:55 Re: Printing backtrace of postgres processes