| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Tender Wang <tndrwang(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(at)vondra(dot)me> |
| Subject: | Re: Add expressions to pg_restore_extended_stats() |
| Date: | 2026-02-04 10:32:46 |
| Message-ID: | CADkLM=cEhnZhSaOn-WAVvhcco9KjpQ-GaJ_+pY-P3Me=DY5zYQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> Okay. It really sounds to me like an ErrorContextCallback would help
> you here. I don't see a need to complicate statatt_build_stavalues(),
> but my intuition can also be wrong.
>
Sigh. errsave_finish() only calls errfinish() on elevel >= ERROR, and
that's where the context stack is walked. The failed work in progress is
attached too, mostly as a cautionary tale.
v5-0001 includes tests for null expressions on the leading and trailing end.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Add-support-for-exprs-in-pg_restore_extended_stat.patch | text/x-patch | 80.8 KB |
| v5-0002-FAILED-WIP-errcontext.patch | text/x-patch | 10.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-02-04 10:46:22 | Re: Change copyObject() to use typeof_unqual |
| Previous Message | Tatsuo Ishii | 2026-02-04 10:22:22 | Re: Row pattern recognition |