| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, jkatz(at)postgresql(dot)org, nathandbossart(at)gmail(dot)com |
| Subject: | Re: Import Statistics in postgres_fdw before resorting to sampling. |
| Date: | 2025-12-14 20:01:35 |
| Message-ID: | CADkLM=c4xX8VhH3naVqz_Sd8A0ffX6u7UXf+AzT7u4dc+wv5Dg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> Ah, I mean the case where the foreign table is an inheritance parent
> on the *local* side. In that case, the return would cause us to skip
> the recursive ANALYZE (i.e., do_analyze_rel() with inh=true), leading
> to no inherited stats. I agree that the case is minor, but I don't
> think that that's acceptable.
>
When such a corner case occurs (stats import configured to true, but table
is an inheritance parent), should we raise an error, or raise a warning and
return false on the CanImportStats() call? I guess the answer may depend on
the feedback we get.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Александр Асафов | 2025-12-14 20:13:49 | Optimization of partial index creation for a new column |
| Previous Message | Tom Lane | 2025-12-14 19:57:48 | Proposed mid-cycle update of typedefs.list |