| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Baji Shaik <baji(dot)pgdev(at)gmail(dot)com> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix --missing-stats-only false positive for partitioned expression indexes |
| Date: | 2026-06-16 16:40:11 |
| Message-ID: | CADkLM=c3UMCPRC3jXzY85kSESUPj29=jqT_gSzqFmrYd9qeTBQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 16, 2026 at 12:26 PM Baji Shaik <baji(dot)pgdev(at)gmail(dot)com> wrote:
> On Tue, Jun 16, 2026 at 11:14 AM Nathan Bossart <nathandbossart(at)gmail(dot)com>
> wrote:
>
>> I'm curious why you added this check to the beginning and surrounded the
>> rest with parentheses. Wouldn't it be better to follow the example of the
>> surrounding clauses and an "AND NOT p.inherited" somewhere in the middle?
>
>
> Good point. v2 moves the check inside the EXISTS as
> "AND NOT p.inherited", consistent with how the inheritance
> sections below handle it.
>
> v2 attached.
>
> Thanks,
> Baji Shaik.
>
+1
The refactor I was testing differed only in having the new qual one line
higher (above the attstattarget check vs below it). Looks good to me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-06-16 16:46:40 | Re: Fix --missing-stats-only false positive for partitioned expression indexes |
| Previous Message | Fujii Masao | 2026-06-16 16:27:35 | Re: Disable startup progress timeout during standby WAL replay |